fix: 1788 show budgets diffs triggered by milestone changes #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BCerki
force-pushed
the
1788-calculated-diffs
branch
3 times, most recently
from
9c4bf7b
to
4e2e22c
Compare
JoshLarouche
approved these changes
Jul 31, 2023
BCerki
force-pushed
the
1788-calculated-diffs
branch
from
b56d0ac
to
76d59a8
Compare
BCerki
force-pushed
the
1788-calculated-diffs
branch
from
76d59a8
to
e25a02b
Compare
Sepehr-Sobhani
approved these changes
Aug 1, 2023
Comment on lines
+33
to
+36
| isEqual( | ||
| formDataIncludingCalculatedValues?.[key], | ||
| oldFormDataIncludingCalculatedValues?.[key] | ||
| ) |
There was a problem hiding this comment.
No suggestions here, I'd like to know why we need to use the lodash here. Is it because we want to compare array objects?
There was a problem hiding this comment.
Yes, the anticipated funding per fiscal year and additional funding are arrays. If we just use ===, they're never equal and we get a diff even when nothing has changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
card: https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/gh/bcgov/cas-cif/1788
Note: Anticipated Funding Per Fiscal Year is no longer in the happo shot. That's correct--the cypress test doesn't change anything that would create a diff in anticipated funding.