chore: fixed the suggested changes

bcgov · Jan 15, 2025 · da22a12 · da22a12
1 parent abad528
commit da22a12
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/bc_obps/registration/tests/endpoints/v1/user/test_user_profile.py b/bc_obps/registration/tests/endpoints/v1/user/test_user_profile.py
@@ -109,7 +109,7 @@ def test_create_user_profile_idir(self):
         # Additional Assertions (If BYPASS_ROLE_ASSIGNMENT is True, app_role should be cas_admin, otherwise cas_pending)
 
         assert (
-            'app_role' in content and content["app_role"]["role_name"] == 'cas_analyst'
+            'app_role' in content and content["app_role"]["role_name"] == 'cas_admin'
             if settings.BYPASS_ROLE_ASSIGNMENT
             else 'cas_pending'
         )

diff --git a/bc_obps/registration/tests/endpoints/v2/user/test_user_profile.py b/bc_obps/registration/tests/endpoints/v2/user/test_user_profile.py
@@ -109,7 +109,7 @@ def test_create_user_profile_idir(self):
         # Additional Assertions (If BYPASS_ROLE_ASSIGNMENT is True, app_role should be cas_admin, otherwise cas_pending)
 
         assert (
-            'app_role' in content and content["app_role"]["role_name"] == 'cas_analyst'
+            'app_role' in content and content["app_role"]["role_name"] == 'cas_admin'
             if settings.BYPASS_ROLE_ASSIGNMENT
             else 'cas_pending'
         )

diff --git a/bc_obps/reporting/api/reports.py b/bc_obps/reporting/api/reports.py
@@ -65,7 +65,6 @@ def save_report(
     request: HttpRequest, version_id: int, payload: ReportOperationIn
 ) -> Tuple[Literal[201], ReportOperationOut]:
     report_operation = ReportService.save_report_operation(version_id, payload)
-    print('report_operation', report_operation)
     return 201, report_operation  # type: ignore
 
 

diff --git a/bciers/apps/reporting/src/data/jsonSchema/operations.ts b/bciers/apps/reporting/src/data/jsonSchema/operations.ts
@@ -28,6 +28,11 @@ export const operationReviewSchema: RJSFSchema = {
       default: "Annual report",
     },
 
+    operation_representative_name: {
+      type: "array",
+      title: "Operation representative",
+    },
+
     date_info: {
       type: "object",
       readOnly: true,