Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/202 operation emission summary page #2658

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

acatchpole
Copy link
Contributor

@acatchpole acatchpole commented Jan 8, 2025

Card: bcgov/cas-reporting#202

The main difference between this page and the existing facility emission summary is that the facility summary uses the
facility_report to aggregate emissions. The operation emission summary uses the report_version to sum up emissions. Doing this captures emissions across the entire operation, rather than just one facility.

To test locally:

  1. navigate to the BCIERS dashboard at http://localhost:3000/dashboard
  2. ensure you are logged in
  3. click on 'Submit annual reports(s)'
  4. click on 'Continue' next to Operation 3
  5. progress through the forms, filling out any needed fields before hitting 'Save & Continue'
  6. Ensure that emission data is added on at least one activity form.
  7. Continue to progress to the Emission Summary page.
  8. Take note of the populated fields
  9. go to the URL http://localhost:3000/reporting/reports/2/emission-summary
    • expect to see the fields on this page are populated identically to the previous emission summary page

@acatchpole acatchpole force-pushed the feat/202-operation-emission-summary-page branch from bd9757f to 5e715d4 Compare January 13, 2025 18:01
@acatchpole acatchpole marked this pull request as ready for review January 14, 2025 01:01
Copy link
Contributor

@pbastia pbastia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good! 🎉
I've left a few comments on where we can improve code re-use and reduce the amounts of database calls. Let me know if you have any questions, happy to pair on any of these items!

@acatchpole acatchpole force-pushed the feat/202-operation-emission-summary-page branch from b0c8d9c to 092136f Compare January 21, 2025 16:52
@acatchpole acatchpole force-pushed the feat/202-operation-emission-summary-page branch from 1692797 to 9ac571e Compare January 29, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants