-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/202 operation emission summary page #2658
Open
acatchpole
wants to merge
14
commits into
develop
Choose a base branch
from
feat/202-operation-emission-summary-page
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+877
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatchpole
force-pushed
the
feat/202-operation-emission-summary-page
branch
from
January 13, 2025 18:01
bd9757f
to
5e715d4
Compare
pbastia
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good! 🎉
I've left a few comments on where we can improve code re-use and reduce the amounts of database calls. Let me know if you have any questions, happy to pair on any of these items!
...p/components/additionalInformation/operationEmissionSummary/OperationEmissionSummaryForm.tsx
Outdated
Show resolved
Hide resolved
...p/components/additionalInformation/operationEmissionSummary/OperationEmissionSummaryForm.tsx
Show resolved
Hide resolved
...p/components/additionalInformation/operationEmissionSummary/OperationEmissionSummaryPage.tsx
Outdated
Show resolved
Hide resolved
...p/components/additionalInformation/operationEmissionSummary/OperationEmissionSummaryPage.tsx
Outdated
Show resolved
Hide resolved
acatchpole
force-pushed
the
feat/202-operation-emission-summary-page
branch
from
January 21, 2025 16:52
b0c8d9c
to
092136f
Compare
acatchpole
force-pushed
the
feat/202-operation-emission-summary-page
branch
from
January 29, 2025 16:29
1692797
to
9ac571e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card: bcgov/cas-reporting#202
The main difference between this page and the existing facility emission summary is that the facility summary uses the
facility_report to aggregate emissions. The operation emission summary uses the report_version to sum up emissions. Doing this captures emissions across the entire operation, rather than just one facility.
To test locally: