Task/migrate operation reg1 statuses/2770 #2868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-williams
force-pushed
the
task/migrate-operation-reg1-statuses/2770
branch
2 times, most recently
from
ca3e675 to
fef7181
Compare
andrea-williams
force-pushed
the
task/migrate-operation-reg1-statuses/2770
branch
from
fef7181 to
c492e2a
Compare
…ly need to do something more with Declined operations
andrea-williams
force-pushed
the
task/migrate-operation-reg1-statuses/2770
branch
from
c492e2a to
db431f5
Compare
BCerki
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Looks good! A couple thoughts:
- running
poetry run python manage.py check_migrations_with_prod_data, runs all the migrations so in the testing instructions, you have to additionally comment out line 69-70 ofcheck_migrations_with_prod_dataif you want to apply the migrations up to 0078 and play around with the before data - if there's anything we'll have to do when we do the migration for real (e.g. remove reg1 statuses from the model choices if we're doing that), we can add to the real migration card so we remember
- Thank you for providing a detailed example I can steal for mine >:)
| approved_operations_updated = Operation.objects.filter(status="Approved").update(status="Draft") | ||
| changes_requested_operations_updated = Operation.objects.filter(status="Changes Requested").update(status="Draft") | ||
| declined_operations_archived = Operation.objects.filter(status="Declined").update( | ||
| archived_by_id='c3bc1b69-15de-44ac-b03b-982bf3163406', archived_at=datetime.datetime.now(datetime.timezone.utc) |
There was a problem hiding this comment.
Is it OK to have a real uuid in a public repo? (I know we have some in our mock data too, but I think we were trying to avoid where possible.) Possibly we could select it from the User model by some other field?
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card: #2770
How to Test/Run:
poetry run python manage.py check_migrations_with_prod_data --pod <pod_name>, where pod_name is the name of a postgres pod in our Openshift PROD envpoetry run python manage.py migrate registration 0078andpoetry run python manage.py migrate reportingto apply all Django migrations except for the migration included in this PRpoetry run python manage.py migrate registration, which will run the migration included in this PR (registration/0079). You'll be able to see the print statements describing what data was affected by the 0079 migration.For testing purposes, the migration in this PR contains assertions and print statements for testing purposes and to demonstrate that the migration is working as expected. These assertions and print statements will be deleted from the migration before merging (it's also why the pre-commit hook is failing).
REMEMBER TO DELETE YOUR LOCAL COPY OF THE PROD DATA ONCE YOU'VE FINISHED TESTING!