Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPR-169 More email notifications #79

Merged
merged 9 commits into from
Jul 10, 2023
Merged

Conversation

dbarkowsky
Copy link
Collaborator

Description

This PR includes the following proposed change(s):

  • Added GC Notify notification for when a record is marked as Incomplete or Complete by admin.
  • Added GC Notify notification for when a record has been Incomplete for too long. Uses cron job.
  • Adjusted original notification to only alert admins when a record is submitted, files and all. Didn't want to alert them twice (once for submission and once for after files were attached)
  • Included option to use the CSS API. Needed to get emails from users. These are not stored.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Version change
  • Dependencies added/removed

Aspect(s) of Project Affected

  • Frontend
  • API
  • Database
  • Workflows
  • Documentation

Best Practices Checklist

  • I have performed a self-review of my own code
  • My code follows the Airbnb React Style Guidelines
  • Documentation has been updated to reflect my changes
  • New and existing tests pass locally with my changes

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Triggered the emails manually.
Used the UI to cause emails to trigger.

@codeclimate
Copy link

codeclimate bot commented Jul 10, 2023

Code Climate has analyzed commit 800635f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.

@dbarkowsky dbarkowsky merged commit 95aa6eb into main Jul 10, 2023
4 checks passed
@dbarkowsky dbarkowsky deleted the SPR-169-More-Email-Notifications branch July 10, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants