Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPR-192 Update Downloaded Triggers #91

Merged
merged 5 commits into from
Jul 17, 2023

Conversation

dbarkowsky
Copy link
Collaborator

Description

This PR includes the following proposed change(s):

  • Changed visibility of downloaded icon to only be seen by admin.
  • Only admins can now trigger the downloaded status.
  • This also now happens in the API only if instigated by an admin.
  • Download all files updates UI with download icons.
  • Added User interface for Keycloak.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Version change
  • Dependencies added/removed

Aspect(s) of Project Affected

  • Frontend
  • API
  • Database
  • Workflows
  • Documentation

Best Practices Checklist

  • I have performed a self-review of my own code
  • My code follows the Airbnb React Style Guidelines
  • Documentation has been updated to reflect my changes
  • New and existing tests pass locally with my changes

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Tested manually in the UI.

app/src/keycloak/utils/User.ts Show resolved Hide resolved
api/keycloak/utils.ts Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Jul 14, 2023

Code Climate has analyzed commit 8167fe9 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.

@dbarkowsky dbarkowsky merged commit ca5d41f into main Jul 17, 2023
5 checks passed
@dbarkowsky dbarkowsky deleted the SPR-192-Update-Downloaded-Triggers branch July 17, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants