fix: FORMS-1451 Restrict form schedule late submission period to integers only #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revanth-banala
requested review from
usingtechnology,
abhilash-aot,
nimya-aot and
RyanBirtch-aot
|
|
|
Release 980d252 deployed at https://chefs-dev.apps.silver.devops.gov.bc.ca/pr-1700 |
| t('trans.formSettings.valueMustBeNumber'), | ||
| ]); | ||
| const scheduleTypedRules = ref([ | ||
| (v) => !!v || t('trans.formSettings.selectAnOptions'), | ||
| ]); | ||
|
|
||
| const handleIntegerInput = (event) => { |
There was a problem hiding this comment.
Did you try using https://vuetifyjs.com/en/components/number-inputs/?
I think that could do what you need?
There was a problem hiding this comment.
I investigated this approach and found there are compatibility concerns v-number-input is currently an experimental component in Vuetify Labs so keeping the current implementation
…ecimal-values-in-fields
…ecimal-values-in-fields
abhilash-aot
approved these changes
Jun 17, 2025
…ecimal-values-in-fields
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Form Submission Schedule allow decimal values for some fields
Description
The form submission schedule has a couple of places where it takes positive integers as values. However, the validation allows values with up to two decimal points.
For some reason if you enter three decimal places then the validation fails.
Expected behaviour: can only enter integer values greater than or equal to 1, and . cannot be entered.
Updated validation regex
Limits range to 1-999 previously it is 6 digits
Updated error message
Added translations
Decimal points can no longer be typed in the field
Type of Change
fix (a bug fix)
Checklist
Further comments