Bug/duplicate users #195
Merged
Bug/duplicate users #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DB migration to remove dupes, add unique constraint on identityId and idp columns
TimCsaky
force-pushed
the
bug/duplicate-users
branch
from
36874bf
to
8722ca5
Compare
jujaga
reviewed
Aug 11, 2023
app/src/db/migrations/20230810000000_009-user-identity-constraint.js
Outdated
Show resolved
Hide resolved
app/src/db/migrations/20230810000000_009-user-identity-constraint.js
Outdated
Show resolved
Hide resolved
conflict behaviour changed with simpler sql queries wrapped whole login process in db transaction
TimCsaky
force-pushed
the
bug/duplicate-users
branch
from
8722ca5
to
e66be84
Compare
Coverage Report
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 03030b1 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 90.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.6% (0.1% change). View more on Code Climate. |
jujaga
approved these changes
Aug 11, 2023
TimCsaky
force-pushed
the
bug/duplicate-users
branch
from
ed46b29
to
03030b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DB migration to remove dupes, add unique constraint on identityId and idp columns
conflict behaviour changed with simpler sql queries
wrapped whole login process in db transaction
ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3297
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist