Ensure coms-id tags buried in history are used when soft-deleted #198
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit a12fb5b and detected 54 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 22.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.0% (-5.5% change). View more on Code Climate. |
Coverage Report
|
The concept of requesting the entire COMS instance to update everything all at once would require a full inspection of all objects and buckets. This will be deferred for now. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
Root level files and folders behave differently than standard "folders" as they are technically in the path when there are no preceeding slashes. This should resolve the side issue where listAllObjectVersions was not usable. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
This method focuses on attempting to acquire a previously known 'coms-id' tag. If it can procedurally find one in the version history, it will yield that uuid; otherwise a new one will be generated. This is expected to only be used when creating new COMS Object DB records. A 'coms-id' will be written back to S3 in the event this is newly assigned. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
jujaga
force-pushed
the
feature/softcomsid
branch
from
a12fb5b
to
50f62e4
Compare
|
Release 1858ad2 deployed at https://coms-dev-pr-198.apps.silver.devops.gov.bc.ca |
| @@ -81,7 +127,8 @@ const service = { | |||
| response[0].versions.find(v => v.id === version.id).metadata = metadata; | |||
| } | |||
| } | |||
| log.verbose(`Finished syncing ${path} in bucket ${bucketId}`, { function: 'syncJob', result: response }); | |||
|
|
|||
| log.verbose(`Finished syncing ${path} in bucket ${bucketId}`, { function: 'syncJob', result: response }); | |||
| return response; | |||
There was a problem hiding this comment.
we don't actually expose this response to the api user.. but it seems like a nice thing to have (a nested array of object>version?meta/tags) for logging.
| * @returns {object} synced objects that exist in COMS and S3 eg: | ||
| * <ObjectModel> (synced object) | ||
| * or `undefined` (when object was pruned from COMS db after sync) | ||
| * @returns {Promise<Array<object | undefined>>} Either an array of synced objects or undefined |
There was a problem hiding this comment.
i think this syncObject method returns just one js object
@returns {Promise<object | undefined>}
| let versions = []; | ||
| // IF this is a new (or existing) object in COMS DB (from step 1) | ||
| // OR doing 'full' sync AND object wasn't deleted |
There was a problem hiding this comment.
some kind of comments here explaining the logic are useful. we could add them later.
I think the current general behaviour is that without full mode, we only sync versions and meta/tags for new objects
Description
This PR focuses on making sure that when objects are soft deleted that their previous coms-id values are still used during synchronization where appropriate.
SHOWCASE-3317
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist
Further comments