-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate default bucket configuration on startup #208
Conversation
0407769
to
d7df35c
Compare
Check for conflict config > database on startup Let getBucket() throw if objectStorage not in config
Function always throws if no bucket found
Code Climate has analyzed commit d5941ae and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 81.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.6% (0.1% change). View more on Code Climate. |
OBJECTSTORAGE_TEMP_EXPIRESIN changed to SERVER_TEMP_EXPIRESIN
d7df35c
to
fdcf16c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking pretty good at a semantic glance. As we are shaking some things up with the helm chart env values, we are going to need to bump the helm chart version so that these changes will actually catch on CI/CD on merge.
c764e61
to
a3d6bdd
Compare
a3d6bdd
to
d5941ae
Compare
Description
ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3337
.. and some other changes required to make the default bucket feature optional.
Types of changes
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments