Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Tokens v3.2.0 release changes #512

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Design Tokens v3.2.0 release changes #512

merged 5 commits into from
Jan 10, 2025

Conversation

Supriya-Arora
Copy link
Contributor

@Supriya-Arora Supriya-Arora commented Jan 10, 2025 •
edited
Loading

This PR includes:

  1. tokens.json is updated to add deprecated token bcds-layout-border-radius-circular.
  2. tokens.json is updated to remove token bcds-typography-font-weights-italic.
  3. Updating build & dist files for v3.2.0
  4. Updating the CHANGELOG for v3.2.0

@Supriya-Arora Supriya-Arora marked this pull request as ready for review January 10, 2025 21:12
@mkernohanbc mkernohanbc added the enhancement New feature or request label Jan 10, 2025
@mkernohanbc mkernohanbc added this to the Components v0.5.0 milestone Jan 10, 2025
@mkernohanbc
Copy link
Contributor

This PR includes:

  1. tokens.json is updated to remove deprecated token bcds-layout-border-radius-circular.
  2. tokens.json is updated to add token bcds-typography-font-weights-italic.

@Supriya-Arora assuming this is just a typo, but just confirming that bcds-layout-border-radius-circular is added and bcds-typography-font-weights-italic is removed, not the other way around?

mkernohanbc
mkernohanbc approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@mkernohanbc mkernohanbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@Supriya-Arora
Copy link
Contributor Author

This PR includes:

  1. tokens.json is updated to remove deprecated token bcds-layout-border-radius-circular.
  2. tokens.json is updated to add token bcds-typography-font-weights-italic.

@Supriya-Arora assuming this is just a typo, but just confirming that bcds-layout-border-radius-circular is added and bcds-typography-font-weights-italic is removed, not the other way around?

Yes my bad, I have updated the comment. Thanks :)

@Supriya-Arora Supriya-Arora merged commit c95b2ec into main Jan 10, 2025
3 checks passed
@mkernohanbc mkernohanbc deleted the feature/design-tokens-v3.2.0 branch January 23, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkernohanbc mkernohanbc mkernohanbc approved these changes

Assignees

@Supriya-Arora Supriya-Arora

Labels
enhancement New feature or request
Projects
None yet
Milestone
Components v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Supriya-Arora @mkernohanbc