Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Join from Request ID to Key #10

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Update Join from Request ID to Key #10

merged 1 commit into from
Nov 14, 2023

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: https://github.com/bcgov/met-public/issues/

Description of changes:

  • Addressed bug causing incorrect survey results after editing. The issue stemmed from the dynamic update of the request ID in the form JSON upon survey editing. This fix removes the dependency on the request ID, replacing it with the constant key column, ensuring consistent behavior even after survey edits.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@VineetBala-AOT VineetBala-AOT merged commit 16dd504 into main Nov 14, 2023
4 checks passed
@VineetBala-AOT VineetBala-AOT deleted the etl-changes branch December 6, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saravanpa-aot saravanpa-aot saravanpa-aot approved these changes

@jadmsaadaot jadmsaadaot Awaiting requested review from jadmsaadaot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VineetBala-AOT @saravanpa-aot