Skip to content

Changes to have all answer options to appear in the report #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: #18

Description of changes:

  • Added new table in analytics to store all available options for each question on the survey
  • ETL changes to load the new table
  • Changes in survey result query to pull all available options along with the survey result.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Merging #24 (c1e28d4) into main (dcb9d28) will increase coverage by 0.49%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   68.54%   69.04%   +0.49%     
==========================================
  Files         472      510      +38     
  Lines       15593    16374     +781     
  Branches     1193     1193              
==========================================
+ Hits        10689    11306     +617     
- Misses       4695     4859     +164     
  Partials      209      209              
Flag Coverage Δ
analyticsapi 79.00% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../analytics_api/models/available_response_option.py 100.00% <100.00%> (ø)
...pi/src/analytics_api/models/request_type_option.py 54.54% <16.66%> (ø)

... and 36 files with indirect coverage changes

@VineetBala-AOT VineetBala-AOT merged commit 9e93cb2 into main Nov 23, 2023
@VineetBala-AOT VineetBala-AOT deleted the available-options branch December 6, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants