Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes required to the Public/Proponent export #27

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: #17

Description of changes:

  • Updated logic to download the file in excel format instead of csv.
  • Updated the template to add formatting

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Merging #27 (0321cfd) into main (bd4931e) will decrease coverage by 0.10%.
The diff coverage is 20.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   68.54%   68.45%   -0.10%     
==========================================
  Files         472      472              
  Lines       15593    15621      +28     
  Branches     1193     1194       +1     
==========================================
+ Hits        10689    10694       +5     
- Misses       4695     4718      +23     
  Partials      209      209              
Flag Coverage Δ
metapi 76.53% <3.44%> (-0.22%) ⬇️
metweb 61.49% <63.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/met_api/services/document_generation_service.py 80.55% <ø> (ø)
met-web/src/apiManager/httpRequestHandler/index.ts 68.18% <87.50%> (+3.47%) ⬆️
...rc/components/comments/admin/textListing/index.tsx 80.00% <0.00%> (ø)
met-web/src/services/commentService/index.tsx 33.33% <0.00%> (-1.97%) ⬇️
met-api/src/met_api/services/comment_service.py 58.71% <3.44%> (-6.60%) ⬇️

... and 1 file with indirect coverage changes

@VineetBala-AOT VineetBala-AOT merged commit f96f33c into main Dec 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants