Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments rejection after engagement is closed #35

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: #17

Description of changes:

  • Backend changes to add new email template
  • Changed the logic to pick existing rejection email template while engagement is open and the new one when engagement is closed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Merging #35 (813617b) into main (e17746e) will decrease coverage by 0.02%.
The diff coverage is 70.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   68.45%   68.44%   -0.02%     
==========================================
  Files         472      472              
  Lines       15620    15624       +4     
  Branches     1194     1194              
==========================================
+ Hits        10693    10694       +1     
- Misses       4718     4721       +3     
  Partials      209      209              
Flag Coverage Δ
metapi 76.50% <70.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/config.py 96.77% <ø> (ø)
met-api/src/met_api/services/submission_service.py 74.62% <70.00%> (-0.77%) ⬇️

@VineetBala-AOT VineetBala-AOT merged commit 6d7fd31 into main Dec 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants