Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reporting-year-options #401

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat: reporting-year-options #401

merged 1 commit into from
Apr 17, 2024

Conversation

banders
Copy link
Contributor

@banders banders commented Apr 17, 2024 •
edited by github-actions bot
Loading

Description

prior to 2025, the only available reporting year is the current year. in 2025 or after both the current year and the previous year are options.

Fixes # GEO-515

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

New unit tests

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

@banders
prior to 2025, the only available reporting year is the current year.…
9c90add 
… 2025 or after both the current year and the previous year are both options.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency Frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jer3k
jer3k reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@jer3k jer3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the backend, will it accept "2023"?

@sukanya-rath sukanya-rath enabled auto-merge (squash) April 17, 2024 18:03
@sukanya-rath sukanya-rath merged commit 6a13816 into main Apr 17, 2024
25 checks passed
@sukanya-rath sukanya-rath deleted the feature/reporting-year-options branch April 17, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jer3k jer3k jer3k left review comments

@sukanya-rath sukanya-rath sukanya-rath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banders @sukanya-rath @jer3k