Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: geo 496 backend external include report and calculation history data to the report if it exists #408

Conversation

goemen
Copy link
Contributor

@goemen goemen commented Apr 17, 2024

Description

  • Refactor report publishing to correctly save the report history
  • Including report history to the external API

Fixes # (issue)
Fixes # ([issue](https://finrms.atlassian.net/browse/GEO-529))

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:


Thanks for the PR!

Deployments, as required, will be available below:

@goemen goemen force-pushed the feat/GEO-496-backend-external-include-report-and-calculation-history-data-to-the-report-if-it-exists branch from 5f00d26 to bbc9d1c Compare April 18, 2024 23:53
Copy link

sonarcloud bot commented Apr 18, 2024

Copy link

sonarcloud bot commented Apr 18, 2024

Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency backend-external'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sukanya-rath sukanya-rath merged commit 433de16 into main Apr 19, 2024
27 checks passed
@sukanya-rath sukanya-rath deleted the feat/GEO-496-backend-external-include-report-and-calculation-history-data-to-the-report-if-it-exists branch April 19, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants