Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GEO-1190 and GEO-1191 - admin report search and dashboard page fixes #819

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

banders
Copy link
Contributor

@banders banders commented Oct 23, 2024

Description

Admin portal changes:

  • Dashboard page: removed the 'sort arrows' from the column header in both tables ("recently submitted" and "recently viewed")
  • Report Search page: Updated the "submission date" filter to map to the "create_date" column (instead of the update_date column). This makes it consistent with how the term "submission date" is used elsewhere on the page and in the app.

Fixes # GEO-1190 and GEO-1191

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

New unit tests. Updated existing unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

…ter key and a sort key. updated the admin frontend report search page such that the 'submission date' filter maps to 'create_date' (instead of update_date)
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency backend-external'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 23, 2024

Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 23, 2024

Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency admin-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sukanya-rath sukanya-rath merged commit daf9052 into main Oct 23, 2024
32 checks passed
@sukanya-rath sukanya-rath deleted the bug/ptap-report-search-date-filter branch October 23, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants