Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GEO-1163 - Rich text support in input form #840

Merged
merged 37 commits into from
Nov 8, 2024
Merged

feat: GEO-1163 - Rich text support in input form #840

merged 37 commits into from
Nov 8, 2024

Conversation

banders
Copy link
Contributor

@banders banders commented Nov 5, 2024 •
edited by github-actions bot
Loading

Description

Fixes # 1163

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

New unit tests

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@banders
alter the type of two columns in the pay_transparency_report table (s…
8e8411a 
…o we can store html content)
@banders
added a new frontend dependency: quill.js
b7158a9
@banders
db migration to change the data type of two columns in the pay_transp…
8490c25 
…arency_report table
@banders
work-in-progress: adding quill rich text editor
e1bb829
@banders
work-in-progress adding rich text editor to input form
a2a56bf
@banders
Merge branch 'main' into feat/ptrt-rich-text
11eed0c
@banders
Merge branch 'main' into feat/ptrt-rich-text
ff74cdc
@banders
added rich text editor to the frontend input form
266cf55
@banders
more progress on rich text support
8d58027
@banders
Merge branch 'main' into feat/ptrt-rich-text
7553154
@banders
support for rich text within the PDF and HTML reports
4aa9451
@banders
validate length of data constraints and employer statement on frontend
ed9ddbf
@banders
fixed unit tests. removed dependency on library 'quill-paste-smart'
1cd7523
@banders banders requested a review from a team as a code owner November 5, 2024 23:02
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency backend-external'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency admin-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency Frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency Backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@banders banders merged commit 794ae13 into main Nov 8, 2024
32 checks passed
@banders banders deleted the feat/ptrt-rich-text branch November 8, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukanya-rath sukanya-rath sukanya-rath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banders @sukanya-rath