Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Code With Us QaQc Dashboard Dec 2023 #2097

Closed

Conversation

AlexZorkin
Copy link
Collaborator

@AlexZorkin AlexZorkin commented Dec 21, 2023

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Added a new 'QaQc Dashboard' to the GWELLS Nav Bar. This is only visible to users with the edit role.
  • The QaQc Dashboard view contains 3 new tables accessible via selectable tabs 'Record Compliance', 'Mislocated Wells', and 'Cross Referencing'
  • Record Compliance: This table shows any well records that are missing required information.
  • Mislocated Wells: This table displays wells that have incongruent location data.
  • Cross Referencing: This table displays well records that have been cross referenced by the internal team.

note: This pr is still a work in progress and will be used for testing for the time being.

@sanjaytkbabu
Copy link
Contributor

Hello Alex,
Looks good, it works on my system. I see the SonarCloud Analysis has failed, Could you take a look at that?
I have also added some comments.
Thank you!

app/scripts/qaqc/gwells_locationqa.py Dismissed Show dismissed Hide dismissed
@AlexZorkin AlexZorkin closed this Jan 12, 2024
@AlexZorkin AlexZorkin reopened this Jan 12, 2024
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

19 New issues
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code

See analysis details on SonarCloud

@AlexZorkin AlexZorkin closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants