Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHANGE][GWELLS-2189] Add well signals tests #2220

Merged
merged 3 commits into from
Apr 25, 2024
Merged

[CHANGE][GWELLS-2189] Add well signals tests #2220

merged 3 commits into from
Apr 25, 2024

Conversation

fergmac
Copy link
Contributor

@fergmac fergmac commented Apr 24, 2024 •
edited
Loading

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Add tests for wells signals
  • Update Makefile test-django rule to allow providing a path, for testing individual test files and individual tests.

@fergmac fergmac self-assigned this Apr 24, 2024
@fergmac fergmac changed the title [CHANGE][GWELLS-2189] Add well signals test [CHANGE][GWELLS-2189] Add well signals tests Apr 24, 2024
LocalNewsTV
LocalNewsTV reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding the teams comment to the PR description for future reference

two things to note about the tests:
They follow the arrange act assert pattern
The naming convention is: "method_being_tested__current_state__expected_outcome"

app/backend/wells/tests/test_signals.py Outdated
self.assertEqual(well.utm_zone_code, 10)
self.assertEqual(well.utm_easting, 533470)
self.assertEqual(well.utm_northing, 5456461)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final line has whitespace in it, being flagged
Tried to add it as a suggestion for simplicity but it just wanted to remove the line instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're using VSC, it does have these two handy functions in Settings
image

@fergmac fergmac requested a review from LocalNewsTV April 24, 2024 18:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fergmac fergmac merged commit b7119d5 into release Apr 25, 2024
9 checks passed
@fergmac fergmac deleted the gwells-2189-migrate-dependencies branch April 25, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalNewsTV LocalNewsTV LocalNewsTV approved these changes

Assignees

@fergmac fergmac

Labels
Backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fergmac @LocalNewsTV @bcgov-csnr-cd