Skip to content

Commit

Permalink
fix(helm): tpl command fixes for args and commands in deployment. (#24)
Browse files Browse the repository at this point in the history
  • Loading branch information
mishraomp authored Nov 17, 2023
1 parent 1356e8f commit b0b39f8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/component/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.0.18
version: 0.1.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
6 changes: 3 additions & 3 deletions charts/component/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ spec:
{{- if .command }}
command:
{{- range .command }}
- "{{tpl . .}}"
- "{{tpl . $}}"
{{- end }}
{{- end}}
{{- if .args }}
args:
{{- range .args }}
- "{{ . }}"
- "{{tpl . $}}"
{{- end }}
{{- end }}
{{- if .envFrom }}
Expand Down Expand Up @@ -180,7 +180,7 @@ spec:
{{- if .args }}
args:
{{- range .args }}
- "{{ . }}"
- "{{tpl . $}}"
{{- end }}
{{- end }}
{{- if (contains "sha256:" .tag) }}
Expand Down
3 changes: 2 additions & 1 deletion charts/component/templates/hpa.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.autoscaling .Values.autoscaling.enabled }}
{{- if and (.Values.global.autoscaling) (and .Values.autoscaling .Values.autoscaling.enabled) }}
apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
Expand Down Expand Up @@ -35,3 +35,4 @@ spec:
averageUtilization: {{ .Values.autoscaling.targetMemoryUtilizationPercentage }}
{{- end }}
{{- end }}
{{- end}}

0 comments on commit b0b39f8

Please sign in to comment.