[MDS-4153] Added missing VFCBC fields to NoW #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matbusby-fw
changed the title
matbusby-fw
commented
Aug 2, 2023
| @@ -31,292 +31,4 @@ describe("ReviewApplicationFeeContent", () => { | |||
| const component = shallow(<ReviewApplicationFeeContent {...props} />); | |||
| expect(component).toMatchSnapshot(); | |||
| }); | |||
|
|
|||
| it("MIN: isApplicationFeeValid === true if `adjustedTonnage` is set and exceeds proposed tonnage for MIN", () => { | |||
There was a problem hiding this comment.
After converting the ReviewApplicationFeeContent component into a functional component, these tests no longer work as you can't spy on functions within a functional component. As this type of testing is generally avoided in favour of user flow testing, I made the decision to get rid of them for now. We have upcoming tickets to implement Cypress tests for high value areas, and I think NoW is definitely one of those.
matbusby-fw
requested review from
simensma-fresh,
henryoforeh-dev,
isuru-aot and
asinn134
matbusby-fw
added
the
👍 Ready for review
asinn134
approved these changes
Aug 2, 2023
henryoforeh-dev
approved these changes
Aug 2, 2023
matbusby-fw
added a commit
that referenced
this pull request
Aug 4, 2023
This reverts commit d04486e.
matbusby-fw
added a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-4153
Update core to accept and display new NoW fields from VFCBC