Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] - don't produce random credential id in method #3307

Merged
merged 51 commits into from
Nov 15, 2024
Merged

[FIX] - don't produce random credential id in method #3307

merged 51 commits into from
Nov 15, 2024

Conversation

Jsyro
Copy link
Collaborator

@Jsyro Jsyro commented Nov 14, 2024

when pushing the publisher, save the id it creates.
when signing and forwarding to the publisher, check the hash for duplicates first then add the id.

@Jsyro
data typing issues and clean up
03e7aa8
@Jsyro
better logging
962f5e9
@Jsyro
better logging of errors
1af241d
@Jsyro
list of tuples
66e22c4
@Jsyro
add celery decorator
4537f18
@Jsyro
rename var to match envvar
fb883b5
@Jsyro
Merge branch 'develop' into feature/issue-to-orgbook-w-publisher
6f49d48
@Jsyro
credential per mine_party_appt produces duplicates.
687e03e
@Jsyro
Merge branch 'develop' into feature/issue-to-orgbook-w-publisher
6cd313b
@Jsyro
wrong class
be179c2
@Jsyro
don't invoke if being used by celery
2652d0f
@Jsyro
query must excluded deleted permit_amendments
7ccd3c0
@Jsyro
add check if cred not created
6ce7067
@Jsyro
improve logging of problem states
a6e44a3
@Jsyro
Merge branch 'develop' into feature/issue-to-orgbook-w-publisher
a95574b
@Jsyro
make date a date, formatting
4ae3465
@Jsyro
revered received date, update issue_Date validator
9e89270
@Jsyro
all datetimes, never dates
6758491
@Jsyro
typo
f68c378
@Jsyro
names are important
5f23ae3
@Jsyro
only use datetime objects, no date objects
6f05801
@Jsyro
better typing
410ddcc 
ensure factory is producing a datetime and not a date
@Jsyro
ensure second is non-zero for datetime
28b35f7
@Jsyro
oops
27fff76
@Jsyro
brackets matter
2a4a118
@Jsyro
what is happening?
9bd7762
@Jsyro
scoping
7b901f2
@Jsyro
factories making dates, should be datetimes.
8546322 
i have no idea anymore
@Jsyro
idk why that today generator suck
46aeab5
@Jsyro
pass callable
c7e04f0
@Jsyro Jsyro changed the title [FIX] - don't produce random id [FIX] - don't produce random credential id in method Nov 14, 2024
taraepp
taraepp previously approved these changes Nov 14, 2024
View reviewed changes
simensma-fresh
simensma-fresh previously approved these changes Nov 14, 2024
View reviewed changes
@Jsyro
type checking would have caught this.
10886e1
@Jsyro
enable basic type checking in vscode.
73ddff5 
slow on startup with MDS being large. it might be indexing package files from other language
@Jsyro Jsyro dismissed stale reviews from simensma-fresh and taraepp via 73ddff5 November 15, 2024 17:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
1 Security Hotspot
35.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Jsyro Jsyro merged commit e48bf3c into develop Nov 15, 2024
10 of 11 checks passed
@Jsyro Jsyro deleted the feature/issue-to-orgbook-w-publisher branch November 15, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taraepp taraepp taraepp approved these changes

@simensma-fresh simensma-fresh simensma-fresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jsyro @simensma-fresh @taraepp