Update Dockerfile #154
Merged
Update Dockerfile #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivid-cpreston
approved these changes
Oct 8, 2024
Update Dockerfile
ssylver93
force-pushed
the
feature/WFPREV-44
branch
from
cef9db9
to
b32cc1f
Compare
Update war path
ssylver93
force-pushed
the
feature/WFPREV-44
branch
2 times, most recently
from
039c6eb
to
b32cc1f
Compare
Update pom.xml
Feature/wfprev 44
Update Dockerfile
Update Dockerfile
ssylver93
force-pushed
the
feature/WFPREV-44
branch
from
c2c16fc
to
7ecbade
Compare
Add webapps volume to server ECS
ssylver93
force-pushed
the
feature/WFPREV-44
branch
from
5ee9fb2
to
5c325ac
Compare
Add spring-boot-autoconfigure
…to feature/WFPREV-44
ssylver93
force-pushed
the
feature/WFPREV-44
branch
from
b84e69f
to
af2d854
Compare
ssylver93
force-pushed
the
feature/WFPREV-44
branch
from
81e5c9b
to
d28fd1b
Compare
ssylver93
force-pushed
the
feature/WFPREV-44
branch
from
4a37bac
to
e486b51
Compare
ssylver93
force-pushed
the
feature/WFPREV-44
branch
from
5fac4e7
to
7780327
Compare
ssylver93
force-pushed
the
feature/WFPREV-44
branch
from
5d287c8
to
3c02d75
Compare
ssylver93
force-pushed
the
feature/WFPREV-44
branch
from
ea5dead
to
ba8ca6d
Compare
yzlucas
approved these changes
Oct 10, 2024
| WEBADE_OAUTH2_CHECK_TOKEN_URL: ${{vars.WEBADE_OAUTH2_CHECK_TOKEN_URL}} | ||
| WEBADE_OAUTH2_CHECK_AUTHORIZE_URL: ${{vars.WEBADE_OAUTH2_CHECK_AUTHORIZE_URL}} | ||
| WFPREV_DATASOURCE_URL: ${{vars.WFPREV_DATASOURCE_URL}} | ||
| WFPREV_DATASOURCE_USERNAME: ${{vars.WFPREV_USERNAME}} |
There was a problem hiding this comment.
I think there are some duplicate variable set up here and variables.tf. ( #DB section below it)
it wont break but we might want to do some housekeeping afterward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the war file into the docker build as pub#wfprev-api.war and add a volume and mount for the webapps directory to ecs.tf