Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CE-615 #51

Merged
merged 6 commits into from
Apr 19, 2024
Merged

fix: CE-615 #51

merged 6 commits into from
Apr 19, 2024

Conversation

barrfalk
Copy link
Contributor

@barrfalk barrfalk commented Apr 16, 2024

Description

Allow users to set a "removed by" action for an equipment, as part of an equipment updaet.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Create an equipment record without a "removed by" action
  • Update the equipment record to include a "removed by" action

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Update variable names
Allow users to update equipment to also set the unset officer
Equipment list on outcomes screen is now maintained in chronological order
Copy link
Collaborator

@Scarlett-Truong Scarlett-Truong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@barrfalk barrfalk added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit e0b2280 Apr 19, 2024
9 checks passed
@barrfalk barrfalk deleted the fix/CE-615 branch April 19, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants