Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-742 #67

Merged
merged 3 commits into from
Jun 20, 2024
Merged

feat: CE-742 #67

merged 3 commits into from
Jun 20, 2024

Conversation

gregorylavery
Copy link
Collaborator

@gregorylavery gregorylavery commented Jun 19, 2024

Modifies the display order and inserts the new 'Less lethal' entry into the right alphabetical place in the listing.

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah bad news @gregorylavery - I don't think there is anything wrong with your scripts, however when I run it the Less Lethal item is at the top. I suspect the problem is in HwcrOutcomeCodeService.findAll. This probably needs some sort of order by added to it.

@gregorylavery
Copy link
Collaborator Author

I can see that problem now, from a process point of view would that be a new bug or can it just be handled here with a re-submit of the PR? I ask just because the UI code is quite different to the SQL changes... @afwilcox

@afwilcox
Copy link
Collaborator

@gregorylavery - you can just make the change in this PR.

@afwilcox afwilcox added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit c151af0 Jun 20, 2024
9 checks passed
@afwilcox afwilcox deleted the CE-742 branch June 20, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants