Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CE-977 create ceeb decison #79

Merged
merged 19 commits into from
Sep 6, 2024
Merged

feat: CE-977 create ceeb decison #79

merged 19 commits into from
Sep 6, 2024

Conversation

marqueone-ps
Copy link
Contributor

@marqueone-ps marqueone-ps commented Sep 3, 2024 •
edited by github-actions bot
Loading

Description

Adds functionality to allow a CEEB officer the ability to add an outcome decision to an enforcement complaint.

Story # CE-977

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Mike Sears added 16 commits August 23, 2024 15:43
@Scarlett-Truong Scarlett-Truong changed the base branch from main to release/red-irish-lord September 3, 2024 21:42
fix: addressed bub found during demo
9d8fdec 
when editing a decision the inspection number was throwing an exception due to type mismatch and not removing the previous lead agency value
Scarlett-Truong
Scarlett-Truong reviewed Sep 5, 2024
View reviewed changes
backend/src/case_file/case_file.service.ts Outdated
@@ -314,7 +335,7 @@ export class CaseFileService {
caseFileId,
ACTION_TYPE_CODES.COSPRVANDEDU,
);

const test = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might remove this

Scarlett-Truong
Scarlett-Truong reviewed Sep 5, 2024
View reviewed changes
backend/src/code-tables/rationale_code/rationale_code.service.ts Outdated
active_ind: true,
},
});
console.log("codes");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might remove this

@afwilcox afwilcox merged commit 92387bb into release/red-irish-lord Sep 6, 2024
9 checks passed
@afwilcox afwilcox deleted the feat/CE-977 branch September 6, 2024 19:28
github-merge-queue bot pushed a commit that referenced this pull request Sep 6, 2024
@afwilcox @marqueone-ps
feat: CE-977 create ceeb decison (#79) (#81)
4b56e12 
Co-authored-by: Mike <100624415+marqueone-ps@users.noreply.github.com>
Co-authored-by: Mike Sears <mike.2.sears@gov.bc.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scarlett-Truong Scarlett-Truong Scarlett-Truong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marqueone-ps @Scarlett-Truong @afwilcox