Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ce 1054 #85

Closed
wants to merge 23 commits into from
Closed

fix: Ce 1054 #85

wants to merge 23 commits into from

Conversation

gregorylavery
Copy link
Collaborator

@gregorylavery gregorylavery commented Sep 17, 2024

Description

Modifies how the CM backend handles the scheduleSectorXref so as to use it only as a reference rather than as a table to be added to.
Includes:

  • script to clear out any existing decision data and add new UK constraint
  • populates the scheduleSectorXref with all valid combinations

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Purge of data testing for decisions and existing schedulesectorxref data was as follows:

  • Delete existing PVC

  • Switch to main branch of case management

  • Add some data to the system to setup a test case so create a few decision entries

  • Switch to this branch

  • Run the migration and therefore the purge script

  • Confirm system works as expected by adding new decisions

  • Test A

  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

migrations/sql/V1.28.1__CE-1054.sql Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants