Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ce 1054 #92

Merged
merged 27 commits into from
Sep 27, 2024
Merged

fix: Ce 1054 #92

merged 27 commits into from
Sep 27, 2024

Conversation

gregorylavery
Copy link
Collaborator

@gregorylavery gregorylavery commented Sep 27, 2024

Modifies how the schedulesectorxref table is used and adds new queries to GraphQL for it.

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

gregorylavery and others added 23 commits September 11, 2024 14:41
barrfalk
barrfalk previously approved these changes Sep 27, 2024
Copy link
Collaborator Author

@gregorylavery gregorylavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the quirk where some entries remain in my DB all looks good.

migrations/sql/R__code-table-data.sql.sql Show resolved Hide resolved
@afwilcox afwilcox added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 3ddcbc2 Sep 27, 2024
9 checks passed
@afwilcox afwilcox deleted the CE-1054 branch September 27, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants