Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Basemap Switcher and Pin Selection State #343

Merged
merged 34 commits into from
Jan 15, 2025
Merged

Conversation

popkinj
Copy link
Contributor

@popkinj popkinj commented Jan 9, 2025

Basemap Options

  • New basemap switcher
  • Examples from ESRI, MapTiler and others.
  • Using a stock library that required building a React component wrapper
  • Currently using the default behaviour and styling of the Leaflet library

Pin Selection State

  • Selected items are styled with an orange marker
  • An additional hover state has been introduced that slightly resizes the map pin on mouseover events

Map Autosearch Adjustments

  • Moved the place names to be first in the search results drop-down

Some screenshots

Slight hover effect scales the pin by 1.2.
Screenshot from 2025-01-13 10-17-03

Place names are now on the top of the Autosearch.
Screenshot from 2025-01-13 10-17-28

Selected items are highlighted.
Screenshot from 2025-01-13 10-18-08

Basemap switcher with 7 example layers.
Screenshot from 2025-01-13 10-18-30


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@popkinj popkinj changed the title Basemaps New Basemap Switcher Jan 9, 2025
@popkinj popkinj changed the title New Basemap Switcher feat: New Basemap Switcher Jan 9, 2025
@popkinj popkinj linked an issue Jan 9, 2025 that may be closed by this pull request
@popkinj popkinj linked an issue Jan 11, 2025 that may be closed by this pull request
3 tasks
@popkinj popkinj changed the title feat: New Basemap Switcher feat: New Basemap Switcher and Pin Selection State Jan 11, 2025
@popkinj popkinj marked this pull request as ready for review January 13, 2025 18:28
@popkinj popkinj requested a review from mishraomp as a code owner January 13, 2025 18:28
@popkinj
Copy link
Contributor Author

popkinj commented Jan 13, 2025

I'm starting to lose my love ❤️ for this basemap plugin.

After moving some things around I noticed it wasn't accepting tap events on mobile... The latest changes make up for that.
Also not happy with the arrangement here. Will look into adding the original basemap button and cram the plugin into our own reveal and hide logic.
Screenshot from 2025-01-13 13-34-03

@mishraomp
Copy link
Contributor

@popkinj could you please look into the sonar issues

@popkinj
Copy link
Contributor Author

popkinj commented Jan 13, 2025

@popkinj could you please look into the sonar issues

Yeah sure. I'll have a look after I make the above changes.

@popkinj
Copy link
Contributor Author

popkinj commented Jan 14, 2025

Tested and working on mobile
Screenshot from 2025-01-14 13-23-23

@mishraomp
Copy link
Contributor

I will wait for @kdbelair to provide his feedback, overall looks great to me, any plans to add e2e test case for the basemap switch @popkinj

@popkinj
Copy link
Contributor Author

popkinj commented Jan 14, 2025

I will wait for @kdbelair to provide his feedback, overall looks great to me, any plans to add e2e test case for the basemap switch @popkinj

That's a good idea @mishraomp . Let's see what comes out of the Sprint Review and any other feedback. Just in case there's more changes.

@popkinj
Copy link
Contributor Author

popkinj commented Jan 15, 2025

Screenshot from 2025-01-15 10-33-07

Copy link

@popkinj popkinj requested a review from mishraomp January 15, 2025 19:13
Copy link
Contributor

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done, lgtm

@popkinj popkinj merged commit 1541de8 into main Jan 15, 2025
20 checks passed
@popkinj popkinj deleted the map/search-231 branch January 15, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants