Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FSADT1-1498): updating cache #1154

Merged
merged 4 commits into from
Sep 13, 2024
Merged

fix(FSADT1-1498): updating cache #1154

merged 4 commits into from
Sep 13, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Sep 13, 2024 •
edited by github-actions bot
Loading

Description

Updated cache to prevent stale data.

  • max-age=1800: Cache for 30 minutes in the browser.
  • s-maxage=1800: Cache for 30 minutes in shared caches like CDNs.
  • stale-while-revalidate=600: If stale, the resource can still be served while it’s revalidated in the background for up to 5 minutes.
  • stale-if-error=3600: Serve stale content for up to 1 hour if an error occurs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • No new tests are required

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@github-actions GitHub Actions
Copy link
Contributor

Current changelog

Bug Fixes

  • FSADT1-1498: updating cache (5974f43)

@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj enabled auto-merge (squash) September 13, 2024 20:04
@paulushcgcj paulushcgcj merged commit 4051a5e into main Sep 13, 2024
22 checks passed
@paulushcgcj paulushcgcj deleted the fix/FSADT1-1498 branch September 13, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fterra-encora fterra-encora fterra-encora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulushcgcj @fterra-encora