Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FSADT1-1280): rate-limit for backend #903

Merged
merged 7 commits into from
Apr 2, 2024
Merged

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Mar 28, 2024

Description

Rate limiting the backend

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • No new tests are required

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Current changelog

Features

  • FSADT1-1280: rate-limit for backend (ba2ee29)
  • FSADT1-1280: reducing haproxy annotations (f8a5404)
  • FSADT1-1280: updating haproxy annotations (c4b94de)
  • FSADT1-1280: updating haproxy annotations (e63d8d7)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

backend/openshift.deploy.yml Outdated Show resolved Hide resolved
Copy link

@basilv basilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest a lower limit.

@github-actions github-actions bot removed the feature label Apr 2, 2024
@github-actions github-actions bot added feature and removed feature labels Apr 2, 2024
@paulushcgcj paulushcgcj marked this pull request as ready for review April 2, 2024 19:55
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj merged commit 0bf884c into main Apr 2, 2024
25 of 27 checks passed
@paulushcgcj paulushcgcj deleted the fix/FSADT1-1280 branch April 2, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants