-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Email Styling Enhancements #1596
Comments
Hi @OlgaLiber2 , do you have mockup for the FOM Submitter role with organization? |
Possible client info formats CanFor Inc (0074124214) CanFor Inc [0074124214] 0074124214 - CanFor Inc CanFor Inc - 0074124214 |
@ianliuwk1019 I updated the mockup. Let me know if you have any questions. |
Hi @OlgaLiber2 , in delegated admin email template enhancement, do you intend to remove this statement (it was in first version)? |
As discussed, we will keep the T&C for delegated admin template and show only for BCEID user. |
Hi @OlgaLiber2 , Do you have the hyper link to the Terms and Conditions so I can add to the template? |
Hi @OlgaLiber2 , Either way it needs the file (pdf) to be converted into into based64 encoded format and send it to the template by code (our FAM backend): I assume we don't like to store the pdf into our project repository, if that's the case, maybe I need to use online tool to covert this pdf into base64 string and deposit it into code to send to GC Notify for email template. Is there a concern for this approach? |
@ianliuwk1019 if it helps at all with the conversion I also have a doc version of T&C |
Thanks @OlgaLiber2 , pdf is good.
I might be wrong, but if this T&C is to be seen among BCEID users (public), then it is probably no concerns with the T&C being saved in code (converted Base64 string). |
No privacy concerns with converting T&C doc online. No concerns on my end with storing it in code/repo - we just need to document the process for how to change the T&C contents in the future. |
Describe the task
Spike done in #1552
Make the email template more scannable
Acceptance Criteria
we want to:
mockup for the desired changes:
Context:
GC Notify's reply (Their respond speed is impressive!).
The text was updated successfully, but these errors were encountered: