Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1596 Implement email styling enhancements #1608

Merged
merged 17 commits into from
Oct 2, 2024

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Sep 26, 2024

Closes: #1596

  • update frontend T&C component to add some note.
  • on GC Notify, create _V2 templates for both regular user template and delegated admin template.
  • update both "server/backend" and "server/admin_management" on GCNotifyEmailService to
    reflect the template id change and params change.
  • update dynamic wording in code for templates parameters.
  • save latest version to project "public" folder to be accessible as a link, and use it for delegated admin template.
  • update granting user and granting delegated admin method to provide data for email params.
  • adjust email template to show scoped client as a point lists.
  • minor other email template adjustments on wording and spacing.

@ianliuwk1019 ianliuwk1019 linked an issue Sep 26, 2024 that may be closed by this pull request
3 tasks
@ianliuwk1019 ianliuwk1019 changed the title feat: #1596 implement email styling enhancements feat: #1596 Implement email styling enhancements Oct 1, 2024
@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review October 1, 2024 16:49
@ianliuwk1019 ianliuwk1019 requested a review from craigyu October 1, 2024 16:51
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, i didn't test it locally since it was tested already

Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Failed Quality Gate failed for 'nr-forests-access-management_admin'

Failed conditions
70.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@ianliuwk1019
Copy link
Collaborator Author

Good work, i didn't test it locally since it was tested already

No problem, definitely need to be tested once it is merged to dev.

@ianliuwk1019 ianliuwk1019 merged commit 51b4cd3 into main Oct 2, 2024
11 of 13 checks passed
@ianliuwk1019 ianliuwk1019 deleted the feat/1596-implement-email-styling-enhancements branch October 2, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Email Styling Enhancements
2 participants