-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #1596 Implement email styling enhancements #1608
Merged
ianliuwk1019
merged 17 commits into
main
from
feat/1596-implement-email-styling-enhancements
Oct 2, 2024
Merged
feat: #1596 Implement email styling enhancements #1608
ianliuwk1019
merged 17 commits into
main
from
feat/1596-implement-email-styling-enhancements
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ianliuwk1019
changed the title
feat: #1596 implement email styling enhancements
feat: #1596 Implement email styling enhancements
Oct 1, 2024
craigyu
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, i didn't test it locally since it was tested already
Quality Gate failed for 'nr-forests-access-management_admin'Failed conditions |
No problem, definitely need to be tested once it is merged to dev. |
ianliuwk1019
deleted the
feat/1596-implement-email-styling-enhancements
branch
October 2, 2024 22:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1596
reflect the template id change and params change.