fix: #1272 revert read write attribute #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ognito seems will auto map it, refs: #1272
|
MCatherine1994
commented
Apr 3, 2024
basilv
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #1272
Got a pipeline error, seems like "username" is not a valid read/write attribute, revert the code back
Have another guess, noticed that for bceid user in Cognito, their user attributes have a
subfield, and it is required, but for the test bcsc user, I didn't see asubfield in the user attributes.And checked our IDP config terraform file, for IDIR and BCEID, we didn't do a username mapping to sub, think Cognito will auto map it, so want to try to remove the username mapping to sub from the BCSC IDP config as well, and see if that brings any difference.
