Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #1264 config prod bcsc #1288

Merged
merged 5 commits into from
Apr 5, 2024
Merged

feat: #1264 config prod bcsc #1288

merged 5 commits into from
Apr 5, 2024

Conversation

MCatherine1994
Copy link
Contributor

@MCatherine1994 MCatherine1994 commented Apr 5, 2024 •
edited
Loading

refs: #1264

  • Config PROD BCSC issuer urls through terraform
  • Remove the gender from attribute mapping
  • Remove gender from the read/write permission maximum list
  • Config AWS DEV to use PROD token url and user info url for BCSC identity provider

@MCatherine1994
Copy link
Contributor Author

MCatherine1994 commented Apr 5, 2024 •
edited
Loading

Hi Ian @ianliuwk1019 , I think the use_override_proxy_endpoints is not related to the flyway, we only use it here when set up token and user info urls

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MCatherine1994 MCatherine1994 merged commit d748585 into main Apr 5, 2024
13 checks passed
@MCatherine1994 MCatherine1994 deleted the feat/1264-config-bcsc branch April 5, 2024 22:19
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Merged
@MCatherine1994 MCatherine1994 mentioned this pull request Apr 8, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianliuwk1019 ianliuwk1019 ianliuwk1019 approved these changes

@basilv basilv Awaiting requested review from basilv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MCatherine1994 @ianliuwk1019