Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #1538 store audit records tests #1605

Merged
merged 84 commits into from
Oct 2, 2024
Merged

feat: #1538 store audit records tests #1605

merged 84 commits into from
Oct 2, 2024

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Sep 24, 2024 •
edited
Loading

Closes #1538

  • add new test_permission_audit_service.py to test scenarios for saving audit records during granting/revoking end users permissions.
  • simple verification addition in test_router_user_role_assignment.py to verify saving audit record service is being called when granting/revoking end user permission.

craigyu added 30 commits August 29, 2024 12:55
@craigyu
feat: create audit permission and code tables
ddfdea7
@craigyu
fix: grant permissions
4d02cb6
@craigyu
Merge branch 'main' into feat/1536-create-the-new-audit-tables
e1bbb00
@craigyu
fix: Merge branch 'main' into feat/1537-create-an-api-to-return-audit…
a979679 
…-information

# Conflicts:
#	server/flyway/sql/V55__create_permission_audit_and_code_tables.sql
@craigyu
feat: add new models def
b4e1904
@craigyu
fix: depreciated utcnow
68eae76
@craigyu
Merge branch 'main' into feat/1537-create-an-api-to-return-audit-info…
61a02b4 
…rmation
@craigyu
feat: add schemas
633b4e2
@craigyu
fix: magic number
b1554d5
@craigyu
fix: model relationship
89e1e55
@craigyu
fix: remove district related code
9116670
@craigyu
use JSONB
7117ecd
@craigyu
fix: use enum
fa22fd5
@craigyu
fix: table args
115af42
@craigyu
fix: mapped columns
d4077f0
@craigyu
fix: naming and comments
4d17a31
@craigyu
fix: file name
47df43e
@craigyu
fix: endpoint template
c91098d
@craigyu
fix: stash changes
1a06216
@craigyu
feat: endpoint complete
8c84367
@craigyu
fix: add tests
298472d
@craigyu
fix: datetime
8bd2270
@craigyu
fix: test data
9bd001a
@craigyu
fix: tests and fixture
72dfa31
@craigyu
fix: test
21d9854
@craigyu
fix: router tests
357023d
@craigyu
fix: tests
b02300d
@craigyu
fix: tests
d6ce4a6
@craigyu
fix: tests
131279c
@craigyu
feat: client-code-gen
95e6830
@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review September 25, 2024 14:31
craigyu
craigyu approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one change request, pre-approved

server/backend/testspg/router/test_router_user_role_assignment.py Show resolved Hide resolved
server/backend/testspg/crud/services/test_permission_audit_service.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ianliuwk1019 ianliuwk1019 merged commit 9542953 into main Oct 2, 2024
12 checks passed
@ianliuwk1019 ianliuwk1019 deleted the feat/1538-store-audit-records-tests branch October 2, 2024 21:59
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigyu craigyu craigyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store audit records when granting/removing user access
2 participants
@ianliuwk1019 @craigyu