Skip to content

Commit

Permalink
Adjust frontend dockerfile.
Browse files Browse the repository at this point in the history
  • Loading branch information
fergmac committed Sep 26, 2024
1 parent 29fe4a8 commit 306c933
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions frontend/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM node:14.21.3 AS build
# FROM node:14.21.3 AS build
FROM node:14.21.3

RUN apt-get update && apt-get install -y \
git \
Expand All @@ -18,8 +19,10 @@ COPY . /app

RUN npm run build

FROM node:14.21.3
CMD run sh -c "npm run serve"

Check warning on line 22 in frontend/Dockerfile

View workflow job for this annotation

GitHub Actions / Builds (frontend)

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/

# FROM node:14.21.3

COPY --from=build /app /app
# COPY --from=build /app /app

CMD ["npm" "run" "serve"]
# CMD ["npm" "run" "serve"]

0 comments on commit 306c933

Please sign in to comment.