Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

feat: Bb 291 implement the blueberry calculation #335

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

GDamaso
Copy link
Contributor

@GDamaso GDamaso commented Aug 7, 2024

Description

Implemented Blueberry calculation.
Things worked as plan for once, so the changes are minor.
Major change in calculation was for the Nitrogen calculation, which has a different logic compared to Raspberries.

Type of changes

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

NMP

image

BB

image

Spreadsheet

image


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@GDamaso GDamaso linked an issue Aug 7, 2024 that may be closed by this pull request
1 task
Copy link
Contributor Author

@GDamaso GDamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

@kcaparas1630 kcaparas1630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🚀

@GDamaso GDamaso merged commit 8a57bc6 into main Aug 7, 2024
27 of 29 checks passed
@GDamaso GDamaso deleted the BB-291-implement-the-blueberry-calculation branch August 7, 2024 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Blueberry Calculation
2 participants