-
Notifications
You must be signed in to change notification settings - Fork 2
feat: [NMP-30] Feature** setup vite pwa #44
Conversation
…pt + swc; Name is to be decided; .gitignore updated
…tion type for the service worker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I 100% commented this on the wrong PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need a manifest to have a proper vite PWA.
Here's the docs https://vite-pwa-org.netlify.app/guide/
You can verify your PWA is valid by running npm run build
-> npm run preview
If you open the browser in Chrome
, you'll be given an option to install your application
If you're using a Mac, PWA support is only on Safari
…ne-2024 into NMP-30-Setup-Vite-PWA
…act plugins as dependencies and not devdependencies
Been able to download the web application in my local device, please test it out on your own device before reviewing thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for me after deleting package-lock.json and node_modules
README would be nice to instruct building before the preview and listing ports being used
Added name, description, and theme_color. Will merge now. |
Description
Installed vite-plugin-pwa to the current frontend application and configured an initial setup for vite pwa with registerType to autoUpdate to specify registration type for the service worker.
Type of changes
Please delete options that are not relevant.
Checklist
Further comments
If there is other configuration that I need to add into this please let me know! Also, pulling from recent branch to a new feature branch is still confusing to me, so I hope I don't make any merge conflicts!
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: