Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

feat: [NMP-30] Feature** setup vite pwa #44

Merged
merged 10 commits into from
May 13, 2024
Merged

Conversation

kcaparas1630
Copy link
Contributor

@kcaparas1630 kcaparas1630 commented May 9, 2024

Description

Installed vite-plugin-pwa to the current frontend application and configured an initial setup for vite pwa with registerType to autoUpdate to specify registration type for the service worker.

Type of changes

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

If there is other configuration that I need to add into this please let me know! Also, pulling from recent branch to a new feature branch is still confusing to me, so I hope I don't make any merge conflicts!


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@kcaparas1630 kcaparas1630 linked an issue May 9, 2024 that may be closed by this pull request
1 task
@kcaparas1630 kcaparas1630 changed the title feat(ci):[NMP-30] Feature** setup vite pwa feat:[NMP-30] Feature** setup vite pwa May 9, 2024
@kcaparas1630 kcaparas1630 changed the title feat:[NMP-30] Feature** setup vite pwa feat: [NMP-30] Feature** setup vite pwa May 9, 2024
Copy link
Contributor

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I 100% commented this on the wrong PR :)

Copy link
Contributor

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need a manifest to have a proper vite PWA.
Here's the docs https://vite-pwa-org.netlify.app/guide/

You can verify your PWA is valid by running npm run build -> npm run preview
If you open the browser in Chrome, you'll be given an option to install your application
If you're using a Mac, PWA support is only on Safari

@kcaparas1630
Copy link
Contributor Author

Been able to download the web application in my local device, please test it out on your own device before reviewing thanks!

@LocalNewsTV LocalNewsTV self-requested a review May 13, 2024 18:38
Copy link
Contributor

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installs as expected, good work :)

CLI recommends adding a theme_color that's missing to make installable, but can install without. Can either remediate with defauling a value to the key, or deal with in the future

image

Copy link
Contributor

@GDamaso GDamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me after deleting package-lock.json and node_modules
README would be nice to instruct building before the preview and listing ports being used

@kcaparas1630
Copy link
Contributor Author

Added name, description, and theme_color. Will merge now.

@kcaparas1630 kcaparas1630 merged commit e8a7e1d into main May 13, 2024
8 checks passed
@kcaparas1630 kcaparas1630 deleted the NMP-30-Setup-Vite-PWA branch May 13, 2024 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Vite PWA
3 participants