feat: Nmp 22 init express api #45
Conversation
…s healthy and ready!'
…-parser; compression; morgan; cors; note: Helmet is advised for improved security but not yet included
…outing logic in one place
…; package.json updated
GDamaso
requested review from
DerekRoberts,
LocalNewsTV,
fergmac,
kcaparas1630 and
Shakespeares-spy
as code owners
There was a problem hiding this comment.
Kicking off the API is a lot of manual work. I left feedback, comments, suggestions and a some praise.
I didn't comment this for the frontend stuff because its boiler plate, but start documenting your code! Look into JSDoc headers, and comment your functions, routers, tops of your files :) It's easier to start now than it is to try and catch up in 4 weeks
The code formatting is good, and the names are descriptive. This is a good start for your project!
I'd recommend using hyphens instead of periods for your filename schema though. I don't think I've ever encountered periods as a convention before.
Sorry for the long PR.
This is not even close to being a long PR! This is a perfectly fine size, especially for the work that went in!
…ed with DotEnv; Added a simple .env.template; Halfway of commenting existing code;
… Added more comments;
Express API Initialized
Added some base middleware in advance and tried to create some initial structure, following the "openshift-quickstart" pipeline.
Sorry for the long PR.
Don't hold back on comments, I appreciate them and will help a lot.
Cheers!
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: