Feature/api definition #85
Conversation
There was a problem hiding this comment.
Looks good, still preliminary in places so no comments on the todo's or commented out bits as that'll get cleaned up later I'm sure.
Notice a lot of hard-coded file names/paths, not sure if we would want to move this into a config/param file. A null check or two won't kill you, though tracing through things it doesn't seem high risk!
| @@ -3,6 +3,7 @@ | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
|
|
|||
| import ca.bc.gov.nrs.vdyp.backend.v1.api.impl.exceptions.NotFoundException; | |||
There was a problem hiding this comment.
Import added, but no other changes so not sure if this is just a useless import or one missing from previous code changes
There was a problem hiding this comment.
nvm, expanded the rest of the class and see it on the rootGet call
| @@ -0,0 +1,36 @@ | |||
| package ca.bc.gov.nrs.vdyp.backend.v1.utils; | |||
There was a problem hiding this comment.
No accounting for null inputs in these, but I assume that's a pretty low likelyhood
|
No description provided.