Update Client Library and API Integration for Backend Changes #92
Conversation
vividroyjeong
commented
Dec 11, 2024
vividroyjeong
commented
- Update client library and API integration to match backend changes
- Re-config proxy for base path(start with '/api') change in backend api
There was a problem hiding this comment.
We shouldn't be disabling ts/es linting. If you're seeing errors popping up, try to correct them appropriately vs. disabling the rules.
Couple questions on the parameter factories around the use of async/promises. If they're required, no worries, just wasn't sure what the purpose of them was.
| @@ -0,0 +1,152 @@ | |||
| /* tslint:disable */ | |||
There was a problem hiding this comment.
We shouldn't be disabling tslint. If you're getting linting errors, it's better to correct them vs. disabling the checks.
Note that Sonar will check them anyway and they'll need to be corrected regardless.
| configuration?: Configuration, | ||
| ) { | ||
| return { | ||
| projectionDcsvPostForm: async ( |
There was a problem hiding this comment.
Why is this async? It includes a promise I'm just not sure why?
There was a problem hiding this comment.
I see the axios config, I just don't see it getting executed
There was a problem hiding this comment.
Is it only for the factory function below?
| import type { RequestArgs } from '../base' | ||
| import type { FileUpload, Parameters } from '../models' | ||
|
|
||
| export const RunHCSVProjectionApiAxiosParamCreator = function ( |
There was a problem hiding this comment.
Same as previous comment, should this be a promise? Doesn't seem to execute anything in an async way
| @@ -0,0 +1,170 @@ | |||
| /* tslint:disable */ | |||
| @@ -0,0 +1,302 @@ | |||
| /* tslint:disable */ | |||
| ...baseOptions, | ||
| ...options, | ||
| } | ||
| const localVarHeaderParameter = {} as any |
There was a problem hiding this comment.
Ideally we don't use any. We should define a type for this if possible.
|
|
@dhlevi Thank you for your last review. I've made the following changes to address your concerns. Please review again.
|
