fix: fixed bad var resolving; feat: added regression tests to pr open

bcgov · Dec 29, 2024 · 2cd0d58 · 2cd0d58
1 parent 1557263
commit 2cd0d58
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/e2e-regression-tests.yml b/.github/workflows/e2e-regression-tests.yml
@@ -94,14 +94,14 @@ jobs:
           working-directory: tests
 
       - uses: actions/upload-artifact@v4
-        if: failure() || ${{inputs.show_artifact}}
+        if: failure() || inputs.show_artifact
         with:
           name: ${{matrix.test}}-${{matrix.browser}} screenshot
           path: tests/cypress/screenshots/
           if-no-files-found: ignore # 'warn' or 'error' are also available, defaults to `warn`
 
       - uses: actions/upload-artifact@v4
-        if: failure() || ${{inputs.show_artifact}}
+        if: failure() || inputs.show_artifact
         with:
           name: ${{matrix.test}}-${{matrix.browser}} video
           path: tests/cypress/videos/

diff --git a/.github/workflows/pr-open.yml b/.github/workflows/pr-open.yml
@@ -81,3 +81,11 @@ jobs:
     secrets: inherit
     with:
       tag: ${{ needs.vars.outputs.pr }}
+
+  e2e-regression-tests:
+    name: E2E Regression Tests
+    needs: [vars, deploys-dev]
+    uses: .github/workflows/e2e-regression-tests.yml
+    secrets: inherit
+    with:
+      target: ${{ needs.vars.outputs.pr }}