feat(2692): create custom action for image scanning #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golebu2020
force-pushed
the
feat/2692
branch
2 times, most recently
from
718ca72
to
d900cc4
Compare
junminahn
reviewed
Oct 23, 2024
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Build Docker Second Image |
There was a problem hiding this comment.
Why do we need to build the second image?
| - name: Build Docker Second Image | ||
| uses: docker/build-push-action@v4 | ||
| with: | ||
| context: context |
golebu2020
force-pushed
the
feat/2692
branch
3 times, most recently
from
685f562
to
f81e1a6
Compare
golebu2020
temporarily deployed
to
tf-keycloak
GitHub Actions
Inactive
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
junminahn
reviewed
Oct 23, 2024
.github/workflows/deploy-test.yml
Outdated
| @@ -176,3 +176,40 @@ jobs: | |||
| { | |||
| "text": ":warning: Deployment to Test failed! [Investigate here](https://github.com/bcgov/platform-services-registry/)" | |||
| } | |||
|
|
|||
| scan-images-for-vulnerabilities: | |||
| needs: [deploy] | |||
There was a problem hiding this comment.
we can run this job in parallel with the deployment job
.github/workflows/deploy-dev.yml
Outdated
| @@ -218,3 +218,52 @@ jobs: | |||
| { | |||
| "text": ":warning: Deployment to Prod failed! [Investigate here](https://github.com/bcgov/platform-services-registry/)" | |||
| } | |||
|
|
|||
| scan-images-for-vulnerabilities: | |||
| needs: [deploy] | |||
There was a problem hiding this comment.
we can run this job in parallel with the deployment job
.github/workflows/deploy-dev.yml
Outdated
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| packages: write |
There was a problem hiding this comment.
are we writing packages?
.github/workflows/deploy-test.yml
Outdated
| - name: App | ||
| uses: ./.github/actions/scan-docker-image | ||
| with: | ||
| image: ${{ env.GITHUB_REGISTRY }}/bcgov/pltsvc:${{ github.sha }} |
| with: | ||
| image-ref: ${{ inputs.image }} | ||
| format: sarif | ||
| output: trivy-results-${{ inputs.image }}.sarif |
There was a problem hiding this comment.
image is a URL contains /, not sure that creating sub directory is ideal for this case; try without the prefix as each job runs one by one?
golebu2020
force-pushed
the
feat/2692
branch
4 times, most recently
from
8d95d51
to
ebe097f
Compare
junminahn
reviewed
Oct 23, 2024
| image: | ||
| description: A docker image | ||
| required: true | ||
| category: |
There was a problem hiding this comment.
let's remove category and use image for sarif category.
There was a problem hiding this comment.
@junminahn Done!
golebu2020
force-pushed
the
feat/2692
branch
5 times, most recently
from
0ce0b96
to
31944fe
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
golebu2020
temporarily deployed
to
tf-keycloak
GitHub Actions
Inactive
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
|
junminahn
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.