This repository has been archived by the owner on May 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Added address to the party #865
Open
WalterMoar
wants to merge
5
commits into
bcgov:master
Choose a base branch
from
WalterMoar:643_address_component
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalterMoar
commented
Mar 23, 2020
- Added a wrapper around the legacy BaseAddress.vue component.
- Added a model for the wrapper.
- Added the model and component to the base party.
bryan-gilbert
approved these changes
Mar 23, 2020
@@ -3,7 +3,7 @@ | |||
:class="getFormClass()" | |||
class="base-party-form" | |||
data-test-id="BaseParty.form" | |||
@input="emitValidity(HEADER, $event)" | |||
@input="emitValid(HEADER, $event)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
WalterMoar
requested review from
bryan-gilbert
and removed request for
bryan-gilbert
March 23, 2020 23:55
Codecov Report
@@ Coverage Diff @@
## master #865 +/- ##
==========================================
+ Coverage 93.71% 97.17% +3.46%
==========================================
Files 59 24 -35
Lines 1336 638 -698
Branches 116 40 -76
==========================================
- Hits 1252 620 -632
+ Misses 82 16 -66
Partials 2 2
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.