Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Added address to the party #865

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added address to the party #865

wants to merge 5 commits into from

Conversation

WalterMoar
Copy link
Contributor

  • Added a wrapper around the legacy BaseAddress.vue component.
  • Added a model for the wrapper.
  • Added the model and component to the base party.

@@ -3,7 +3,7 @@
:class="getFormClass()"
class="base-party-form"
data-test-id="BaseParty.form"
@input="emitValidity(HEADER, $event)"
@input="emitValid(HEADER, $event)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@WalterMoar WalterMoar requested review from bryan-gilbert and removed request for bryan-gilbert March 23, 2020 23:55
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #865 into master will increase coverage by 3.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
+ Coverage   93.71%   97.17%   +3.46%     
==========================================
  Files          59       24      -35     
  Lines        1336      638     -698     
  Branches      116       40      -76     
==========================================
- Hits         1252      620     -632     
+ Misses         82       16      -66     
  Partials        2        2
Flag Coverage Δ
#python_unittests 97.17% <ø> (ø) ⬆️
Impacted Files Coverage Δ
ppr-api/src/schemas/financing_statement.py 100% <0%> (ø) ⬆️
...-ui/src/financing-statement/FinancingStatement.vue
ppr-ui/src/components/FormSectionHeader.vue
ppr-ui/src/utils/axios-auth.ts
...c/financing-statement/financing-statement-model.ts
ppr-ui/src/search/search-regnum-ui.ts
...rc/financing-statement/financing-statement-type.ts
ppr-ui/src/financing-statement/SecuredParties.vue
ppr-ui/src/views/FinancingStatementView.vue
ppr-ui/src/views/ResultsPage.vue
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d4aea4...43e42bd. Read the comment docs.

@WalterMoar WalterMoar changed the title 643 address component Added address to the party Mar 24, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants