Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Financing Statement select and change type. #871

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bryan-gilbert
Copy link
Contributor

Add a confirmation dialog component.
When Repairer's Lien elements are added will need to toggle their display based on selected type.
May wish to only show the confirm change dialog after user has actually made a change.

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #871 into master will decrease coverage by 0.58%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   93.78%   93.19%   -0.59%     
==========================================
  Files          59       61       +2     
  Lines        1352     1382      +30     
  Branches      118      119       +1     
==========================================
+ Hits         1268     1288      +20     
- Misses         82       92      +10     
  Partials        2        2
Flag Coverage Δ
#python_unittests 97.19% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...-ui/src/financing-statement/FinancingStatement.vue 100% <100%> (ø) ⬆️
ppr-ui/src/components/DialogConfirm.vue 60% <60%> (ø)
ppr-ui/src/financing-statement/TypeComponent.vue 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2b960...e3afb96. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@jguertin jguertin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I certainly wouldn't mind if the coverage checks stopped wining when coverage drops, but I still like general reporting of coverage, in particular on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants