Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD update for PPR API and MHR API. #2080

Merged
merged 5 commits into from
Dec 10, 2024
Merged

CI/CD update for PPR API and MHR API. #2080

merged 5 commits into from
Dec 10, 2024

Conversation

pwei1018
Copy link
Collaborator

@pwei1018 pwei1018 commented Dec 10, 2024

Issue #: 19208

Description of changes:

  1. PPR API CI/CD flow update;
  2. MHR API CI/CD create;
  3. Fixed some configuration items and vaults;
  4. Clean up unused devops files;

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should deploy-env: "test" also match existing config:

def get_named_config(config_name: str = "production"):

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup Patrick, looks great.

@pwei1018 pwei1018 merged commit 95ec1a2 into bcgov:main Dec 10, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants