Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): node 22 (and drop alpine) #345

Merged
merged 3 commits into from
May 22, 2024
Merged

chore(ci): node 22 (and drop alpine) #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c40cb69
chore(ci): node 22 (and drop alpine)
DerekRoberts May 22, 2024
915e1a2
Merge branch 'main' into feat/ci/node22
DerekRoberts May 22, 2024
7f2457f
Missed one
DerekRoberts May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions api/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
FROM node:20-bullseye-slim AS builder
# Build static files
FROM node:22.2.0-slim AS build
WORKDIR /app
COPY *.json ./
RUN npm ci --omit=dev --ignore-scripts
COPY ./src ./src

# Deployment container
# Deployment container
FROM gcr.io/distroless/nodejs20:nonroot
FROM gcr.io/distroless/nodejs22:nonroot
ENV NODE_ENV production

# Copy over app
WORKDIR /app
COPY --from=builder /app/node_modules ./node_modules
COPY --from=builder /app/src ./src
COPY --from=build /app/node_modules ./node_modules
COPY ./src ./src

# Expose port - mostly a convention, for readability
EXPOSE 3000
Expand Down
2 changes: 1 addition & 1 deletion frontend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build static files
FROM node:alpine AS build
FROM node:22.2.0-slim AS build

WORKDIR /app
COPY . .
Expand Down
Loading